Render managed auth field input modes - #29
Open
masnwilliams wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
changed the base branch from
hypeship/render-identifiers-as-text
to
main
August 31, 2026 22:16
masnwilliams
changed the base branch from
main
to
hypeship/render-identifiers-as-text
August 31, 2026 22:16
masnwilliams
changed the base branch from
hypeship/render-identifiers-as-text
to
main
August 31, 2026 22:39
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0770c2a. Configure here.
akxue
approved these changes
Sep 1, 2026
akxue
left a comment
There was a problem hiding this comment.
reviewed — lgtm, approve. two non-blockers:
packages/managed-auth-react/src/components/UnifiedAuthForm.test.ts— worth adding a test pinning the ordering:input_modeshould take precedence over the ref-based username heuristic (e.g.ref: "username"+input_mode: "email"→"email"), so the precedence is deliberate rather than emergentpackages/managed-auth-react/src/session/state.ts:68— nit:...(field.input_mode ? { input_mode: field.input_mode } : {})can just beinput_mode: field.input_modesince the prop is already optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
input_modevalues in the existing UI modelinputModeprop while keeping identifier inputs astype="text"dependencies
testing
bun testbun run buildbun run typecheckbun run format:checkNote
Low Risk
UI-only input typing and autofill hints for login forms; backward compatible when
input_modeis omitted.Overview
Adds optional
input_modeon canonical managed-auth fields and threads it through normalization intoDiscoveredField, exporting the newInputModetype from the package.Identifier handling: canonical
identifierfields always render astype="text"(no more inferringemail/telfromref), so combined login fields accept any format without browser-native validation.inputModeandautoCompletenow followinput_modewhen set (email/tel), while OTP fields still preferone-time-code; mixed identifier fields withinput_mode: "text"no longer get email autofill.UnifiedAuthFormpassesinputModeon password and text inputs. Tests cover autocomplete precedence, DOM props, and state projection.Reviewed by Cursor Bugbot for commit a157e0b. Bugbot is set up for automated code reviews on this repo. Configure here.