Report live view timeouts to parent frame - #362
Conversation
b3ee84c to
8c850ad
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c850ad. Configure here.
| if (readOnly) { | ||
| if (releaseControl) { | ||
| this.$accessor.remote.release() | ||
| } |
There was a problem hiding this comment.
Parent lock loses local lock
Medium Severity
Parent-frame lock calls release and then setLocked(true), but the control/release handler runs remote.reset(), which clears locked. The local lock that is supposed to block input even if hosting is granted again does not persist, so a later control/locked can restore input while the embedder still believes the view is read-only.
Reviewed by Cursor Bugbot for commit 8c850ad. Configure here.


tldr
Telemetry only: post live-view connection timeouts and ICE candidate diagnostics from the Neko client to the dashboard parent frame, and let the parent toggle read-only mode without remounting the iframe.
why
hypeship/live-view-recoverystack, notmain. It listens forKERNEL_CONNECTION_TIMEOUT, so the dashboard's classifier has no production trigger until this lands on the image path.52a22b79relay-escalation commit that was on this branch's previous head changes global ICE policy (relay-only on retry). That is out of scope for GPU OOM (Steven's review on #3733: retry does not address the confirmed OOM failure path) and is deferred to the generic-recovery rescope.connectingand loses ICE context.what landed
images/chromium-headful/client/src/neko/base.ts: on the 15s connect watchdog, postKERNEL_CONNECTION_TIMEOUTto the parent frame with state and candidate summaries (type, protocol, address family).images/chromium-headful/client/src/app.vue: accept parent-frameKERNEL_SET_READ_ONLYmessages instead of forcing a remount.52a22b79) or the autoiceTransportPolicyoverride; those are deferred.16605715) went away as well — not needed for parent-frame telemetry.out of scope