Repository navigation
feat(github): redeliver failed webhooks - #105
Closed
kerdofficial wants to merge 2 commits into
Closed
kerdofficial wants to merge 2 commits into
kerdofficial wants to merge 2 commits into
Conversation
Contributor
Author
claude-opus-5-5 RESPONDING ON BEHALF OF DANISuperseded by #109, which combines this change with the rest of the night's reliability work in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub never redelivers a webhook that failed or timed out, so a lost
workflow_jobevent left its job invisible until a machine scan found it, or forever when no machine scanned.A Convex cron runs every two minutes, lists the App's webhook deliveries since a checkpoint, and asks GitHub once per delivery GUID to redeliver events Vectis handles that never got a 2xx. Work per run is bounded (pages, redeliveries, time), a GUID is never requested twice, the checkpoint only moves after a complete scan, and an idle run costs one checkpoint read and write. Delivery IDs are kept as strings because GitHub's IDs exceed JavaScript's safe integer range.
Proof: convex tests with stubbed deliveries; on the dev deployment the cron ran against the real GitHub API (first exposing the unsafe-integer IDs, now covered by a test), and after a simulated two-minute webhook outage it requested redelivery of every failed delivery.
runner-access.test.tspwsh hook tests time out only under parallel load and pass alone, as on main.