Repository navigation
fix(release): smoke Windows archives with the system tar - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On Windows,
scripts/smoke-release.mjsextracts archives with%SystemRoot%\System32\tar.exeand starts Windows PowerShell without the inheritedPSModulePath.Why
The v0.2.1 release run (39892538938) failed in
smoke-windowswithtar: Cannot connect to C: resolve failed. The Windows guest now finds GNU tar first on PATH and runs steps under PowerShell 7, the same change #73 handled for the updater and installer tests. Publication was skipped, so nothing was released.Checklist
pnpm checkpasses locallyProof: a local darwin-arm64 package passes the smoke test and
pnpm test:packagingpasses. This PR's Windows CI does not run the release smoke, so the Windows proof comes from the next release run.