Repository navigation
Fix/palindrome separator collision - #2772
Merged
keon merged 2 commits intoSep 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
longest_palindromewhen the input contains#.Problem
longest_palindrome("a#a")returned"aa", which is not a substring of the input. The algorithm used#as an internal separator and removed all#characters from the result.Changes
"a#a"and"##".Testing
python3 -m unittest discover -s tests -p 'test_string.py' -v— 68 tests passed.Related issue
Issue #2771
Fixes #2771