Repository navigation
feat(embedconfig): expose literal role affixes and dimension requests - #165
Open
salmonumbrella wants to merge 1 commit into
Open
salmonumbrella wants to merge 1 commit into
salmonumbrella wants to merge 1 commit into
Conversation
roborev: Combined Review (
|
Author
|
@wesm can you unblock workflow execution for this PR, approving the runs if GitHub requests approval or re-running them after checking the gate? Both current-head runs ended Head is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Expose literal document/query prefixes and suffixes and an explicit
request_dimensionsflag inembedconfig.Embedder. Empty affixes and a false flag preserve existing identities and requests.Why
Text retrieval models can need distinct document and query prompts. Applications using the standard TOML configuration currently have to recreate keys that the low-level client already supports. These options let them use the shared configuration directly.
Usage
Affixes preserve whitespace.
dimsalways validates the returned width; opt intorequest_dimensionsonly when the endpoint supports it. Kit never slices vectors. The executable text example describes the serving requirements; model inference remains untested.Closes #164.