Skip to content

ci(lint): ban raw os.Rename in production code #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesm merged 2 commits into from
Oct 5, 2026
Merged

ci(lint): ban raw os.Rename in production code #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b4b529
ci(lint): forbid os.Rename in production code
rodboev Oct 5, 2026
af3d083
ci(lint): narrow os.Rename message and key test exclusion on it
rodboev Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ linters:
msg: Keep storage and API datetimes in UTC; local conversion belongs in the UI.
- pattern: '^time\.FixedZone$'
msg: Keep storage and API datetimes in UTC; local conversion belongs in the UI.
- pattern: '^os\.Rename$'
msg: Use atomicfile.Replace from go.kenn.io/kit, or atomicfile.RenameNoReplace when the target must not exist, so a Windows reader that opened the target with share-delete can't block the rename.
analyze-types: true
exclusions:
generated: lax
Expand All @@ -61,6 +63,10 @@ linters:
- linters:
- errcheck
path: _test\.go
- linters:
- forbidigo
path: _test\.go
text: atomicfile\.Replace
paths:
- third_party$
- builtin$
Expand Down
Loading