Refuse an unroutable hostname at the API door too - #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 refused a hostname Sozu would read as a pattern — one containing
/becomes a regex, a bare*matches every host — on two doors: the label parser and the HTTP provider. The API was left open, so a single POST or PUT could still install a rule atRulePosition::Prein front of every legitimate route.Both handlers now apply the same gate and answer 400, naming the offending value. A leading
*.stays accepted; that is a wildcard Sozu handles natively.Found by an adversarial review of #140-#145, which noted the gate was not a system-wide invariant: it held for labels and the HTTP provider only.