DB/AWS/Flat/release #14
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| contents: write # Required to create releases |
There was a problem hiding this comment.
The new top‑level permissions block only grants contents: write. When you specify the block, all other scopes default to none, so the job token loses the actions permissions required by actions/upload-artifact@v4 and actions/download-artifact@v4. As a result, artifact upload in build-release and download in create-release will fail with “Resource not accessible by integration”, preventing any release assets from being produced. Add the necessary actions: write (and at least actions: read for the download step) to restore functionality.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GitHub Actions release workflow with improved cross-platform build support, particularly for ARM64 Linux compilation. The changes focus on streamlining the release process with better artifact handling and proper GitHub API usage.
Key changes:
- Added explicit workflow permissions for release creation
- Enhanced cross-compilation support with OpenSSL and pkg-config setup for ARM64 Linux
- Improved artifact handling by flattening downloaded artifacts into a release-assets directory
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .gitignore | Added .DS_Store entries to exclude macOS system files |
| .github/workflows/release.yml | Enhanced release workflow with proper permissions, improved cross-compilation environment for ARM64 Linux, streamlined cache configuration, better artifact handling with flattening step, and corrected GitHub API reference usage (github.ref_name instead of github.ref) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Install cross-compilation toolchain (Linux ARM64) | ||
| if: matrix.os == 'ubuntu-latest' && matrix.target == 'aarch64-unknown-linux-gnu' | ||
| run: | | ||
| sudo apt-get update |
There was a problem hiding this comment.
Duplicate sudo apt-get update command. Line 47 already runs sudo apt-get update before adding the architecture, and it's run again on line 49. The first update on line 47 can be removed since the second update on line 49 (after adding the arm64 architecture) will refresh the package lists with the newly added architecture sources.
| sudo apt-get update |
Adding in aws secrets management
adding in dba as a target
updated folder structure
updated release management
added tests but we should move these out of src later
This pull request updates the GitHub Actions workflow for releases, focusing on improving permissions, environment configuration, cross-compilation support, and release asset handling. The main goal is to ensure smoother cross-platform builds and more robust release creation.