Open
Conversation
Add waitConfirmations to make the deployment smooth on public ethereum networks.
Configuration needed for deployment on goerli.
We clean up more data
Closed
Use more recent versions of hardhat packages.
We want to be able to configure private keys to multiple accounts for example on goerli network to be able to run initialization scripts. With this change we expect the environment property to define one or more private keys separated with a comma (`,`). The change is made also to the variable name, to better reflect the meaning.
This reverts commit 1d92e3d.
For tests we don't want to start nammed accounts with 0 as this is a default account used by the provider and may cause some false-positive results. We explicitly start with 1.
Update plugins to the latest versions.
| contract: "UniswapV2RouterStub", | ||
| from: deployer, | ||
| log: true, | ||
| waitConfirmations: 1, |
Contributor
There was a problem hiding this comment.
Out of curiosity - why don't we add the same for deployments in the earlier scripts?
Member
Author
There was a problem hiding this comment.
We use stubs on the hardhat network for unit tests and it works stable there.
3 tasks
Contributor
Member
Author
|
I replied in #215 (comment). |
Member
|
What is the status of this PR @nkuba @michalinacienciala ? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add configuration that is needed for Goerli contracts deployment.