dev-generic - #134
Merged
Merged
Conversation
…his is not present in this branch for now.
…pes, to point towards a generic file reader.
…given in the documentation (regardless of the RunLabel).
…ues to Planck 2018 ones and issuing a warning. Also adding a catch for when Elements are not specified in their own group in a generic file.
…nd set if missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #133 - when a generic HDF5 file is written according to the formats outlined in the documentation, the code should behave as expected. In this case, gas will be assumed to follow a Wendland 2 kernel profile for oversampling purposes. Tests have been added to ensure inputs with a "RunLabel" in the header that is not of a supported simulation will be routed through the "generic" processing pathway.
Will close Issue #133 once documentation has further been updated to reflect this, but merging this into main.