Skip to content

Add stricter clippy rules#510

Merged
MatthewMckee4 merged 3 commits intomainfrom
strict-clippy
Mar 11, 2026
Merged

Add stricter clippy rules#510
MatthewMckee4 merged 3 commits intomainfrom
strict-clippy

Conversation

@MatthewMckee4
Copy link
Copy Markdown
Member

@MatthewMckee4 MatthewMckee4 commented Mar 11, 2026

Summary

Enabled almost all clippy rules, and allowed some extra ones.

Also extracted logic from karva/src/lib.rs into dedicated commands folder.

Test Plan

prek run -a

@MatthewMckee4 MatthewMckee4 added the internal An internal refactor or improvement label Mar 11, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 11, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1 untouched benchmark


Comparing strict-clippy (8811c98) with main (3ab75ef)

Open in CodSpeed

MatthewMckee4 and others added 2 commits March 11, 2026 11:07
Make the snapshot dispatcher a pure match, with each subcommand
owning its own cwd resolution and printer/stdout setup.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The stricter clippy commit (eee46b5) removed the newline push from
the else branch to fix `branches_sharing_code` but didn't move it
after the if/else, causing all lines to be concatenated together.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@MatthewMckee4 MatthewMckee4 merged commit f74c368 into main Mar 11, 2026
9 checks passed
@MatthewMckee4 MatthewMckee4 deleted the strict-clippy branch March 11, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant