feat(e2e): playwright golden-path smoke (sub-PR 7 of 2026.5)#1072
Open
danh91 wants to merge 4 commits into
Open
feat(e2e): playwright golden-path smoke (sub-PR 7 of 2026.5)#1072danh91 wants to merge 4 commits into
danh91 wants to merge 4 commits into
Conversation
…core) (#1068) Exported from jtlshipping/shipping-platform main via ./bin/export-karrio-patches --force per PRDs/SUBTREE_SYNC_WORKFLOW.md. 1445 files across modules/connectors (579), modules/core (198), apps/api (160), modules/manager (113), modules/pricing (75), modules/sdk (55), modules/events (46), modules/orders (39), modules/data (36), modules/documents (28), modules/graph (25), modules/admin (24) + packages, plugins, scripts, and PRDs. Major functional additions from shipping-platform: - rate sheet Excel/CSV import/export (apps/, packages/, modules/data/) - Playwright e2e package scaffold (packages/e2e/) - dhl_parcel_de improvements (optional dims, reference fallback) - carrier i18n translation expansions (dhl_parcel_de, asendia) - ruff-format reflow across the tree from SP's linter config 54 three-way conflicts resolved per SUBTREE_SYNC_WORKFLOW.md matrix (see PR body for per-file decisions). Smartkargo, FedEx signature defaults, rate-sheet UX variants, and graph archive/unarchive kept at upstream (ours); carrier i18n dicts merged; e2e fixtures and de locale compiled catalog copied directly from SP. Pre-excluded from apply: 10 phantom-deletions of SP-experimental credential/secret modules that never reached upstream, and 5 binary-new files that needed direct copy (xlsx fixtures, django.mo). No JTL-proprietary modules in diff.
- Chromium + Firefox projects with retries/trace/video on CI. - KarrioApi REST helper (JWT bearer auth) for fast seeding. - Shared role-based selectors, env resolution, stack-health poller. - Playwright test fixture extending with an authenticated api client. refs #1065
14 golden-path specs covering the dashboard smoke surface: - auth (3): authenticated home, session reload, guest redirect. - shipment (4): REST seeding, list view, create entry point, API round-trip. - tracking (2): trackers list, public tracking lookup. - order (2): orders list, draft-order entry point. - settings (3): api keys, carrier connections, organization profile. Specs use the KarrioApi REST helper for data seeding and role-based locators for assertions — no CSS class dependencies. refs #1065
- docker-compose.e2e.yml: db + api + dashboard + wiremock carrier stub, tmpfs postgres, no redis (worker runs in-process), healthchecks drive `docker compose up --wait`. - WireMock mappings for rate/shipment/tracking — no live carrier calls. - scripts/seed.ts: idempotent REST-based seed (address + parcel). - New `e2e` GitHub Actions job: boots the stack, installs browsers, seeds, runs specs/, uploads report + traces + videos on failure. - README refresh covering layout, env vars, local vs CI invocation. refs #1065
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Playwright golden-path smoke suite wired into CI as a new
e2ejob so the 2026.5 platform upgrade has an executable browser-level safety net. 14 specs cover auth / shipments / tracking / orders / settings against a stubbed carrier, running in a dedicated Docker compose stack.Part of the 2026.5 umbrella release (#1065), sub-PR 7.
Decisions
e2e/vspackages/e2e/)packages/e2e/— already landed as a workspace package from the shipping-platform sync; expanded rather than parallel-created.wiremock/wiremock:3.9.1with canned JSON mappings inpackages/e2e/fixtures/wiremock/— zero live carrier credentials in CI.npm— matches the repo (rootpackage.jsonpinsnpm@10.8.2); task mentioned pnpm but the monorepo is npm-based.PRDs/RELEASE_2026_5_PLATFORM_UPGRADE.mdwas not present in this worktree; implementation followed the sub-PR 7 scope described in the task brief.Changes
Feat
packages/e2e/playwright.config.ts— Chromium + Firefox projects,retries: 2on CI,trace: "on-first-retry",video: "retain-on-failure", GitHub + HTML reporters.packages/e2e/fixtures/auth.ts— extended Playwrighttestwith an authenticatedKarrioApifixture.packages/e2e/helpers/api.ts— REST client wrapping Playwright'srequest; JWT bearer auth via/api/token.packages/e2e/helpers/selectors.ts— shared role-based locators (no CSS class dependencies).packages/e2e/helpers/env.ts,helpers/wait-for-stack.ts— env resolution + health-poll helper.packages/e2e/specs/— 14 smoke specs:auth.spec.tsshipment.spec.tstracking.spec.tsorder.spec.tssettings.spec.tspackages/e2e/scripts/seed.ts— idempotent REST-based data seed.docker-compose.e2e.yml— minimised CI stack: Postgres (tmpfs) + API + dashboard + WireMock carrier stub; no Redis.packages/e2e/fixtures/wiremock/— canned rate / shipment / tracking JSON..github/workflows/tests.yml— newe2ejob: boots compose, installs browsers, seeds tenant, runs specs, uploads HTML report + traces + videos as artifacts on failure.Why
Goal G6 of the 2026.5 release: browser-level smoke coverage before any release tag is cut. Edge case E5 (regression slipping through despite green unit tests) is mitigated by the required
e2egate onrefs/tags/2026.*pushes.Verification
specs/*.spec.ts)playwright.config.ts)fixtures/wiremock/*.json).github/workflows/tests.ymle2ejob)docker compose -f docker-compose.e2e.yml up -d --waitnpm --prefix packages/e2e testFollow-ups
e2ea required check onrefs/tags/2026.*, the repo-settings rule needs to be updated manually (the workflow itself does not enforce this).retries: 2.tests/rate-sheet-editor.spec.tsremains untouched; the newspecs/directory is the smoke home.