Fix #3486: ShreddedPaper 1.21.11-33 – /mail new or /mail send to offline player triggers "Thread failed main thread check" (inventory modification)#3487
Closed
kangobot[bot] wants to merge 1 commit intomasterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix proposed by AI analysis of the linked issue.
Changes
main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/command/CommandMail.java: Wrap inventory modification in Remain.runEntityTask to fix Folia/ShreddedPaper thread check error when sending mailmain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/command/CommandMail.java: Add Remain import for runEntityTask usagemain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/BookListener.java: Use Remain.runEntityTask for inventory modification to fix Folia/ShreddedPaper thread check errormain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/BookListener.java: Add Remain import for runEntityTask usagemain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/command/CommandMail.java: Wrap /mail new inventory modification in Remain.runEntityTask for Folia/ShreddedPaper safety (especially when invoked from reply flow via syncCallback)main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/PlayerListener.java: Use Remain.runEntityTask for inventory modification to fix Folia/ShreddedPaper thread check errormain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/PlayerListener.java: Use Remain.runEntityTask for updateInventory to fix Folia/ShreddedPaper thread check errormain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/BookListener.java: Remove duplicate Remain importmain/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/listener/BookListener.java: Remove now-unused Platform import since Platform.runTask was replaced with Remain.runEntityTaskThis is a draft PR — human review required before merging.