feat: enable environment-based logging control via ENVIRONMENT and LOG_LEVEL - #497
Closed
MetehanAydemir wants to merge 4 commits into
Closed
feat: enable environment-based logging control via ENVIRONMENT and LOG_LEVEL#497MetehanAydemir wants to merge 4 commits into
MetehanAydemir wants to merge 4 commits into
Conversation
Merge dev into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #486. The
ENVIRONMENTandLOG_LEVELvalues inbackend/app/core/constants.pywere hardcoded ("development"/"DEBUG"), so the corresponding environment variables — already plumbed into the containers bydocker-compose.yml— had no effect. Logging behavior could not be changed per environment without editing code.This reads both values from the environment, with the previous hardcoded values kept as defaults:
ENVIRONMENT's effect is logging-only (console format JSON vs. colored, level); it does not gate security, DB, or CORS behavior.Testing
Verified against the built backend image via docker compose:
development/DEBUG(unchanged; no regression)ENVIRONMENT=production LOG_LEVEL=WARNING→ code now resolvesproduction/WARNINGENVIRONMENT=production, logs are emitted as JSON (was colored human-readable before)GET /healthandGET /api/v1/nodesboth return 200