fix: Diff check fixes for Xendit Authorize flow #357
Merged
+123
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopikrishna000
previously approved these changes
Dec 12, 2025
gopikrishna000
previously approved these changes
Dec 12, 2025
| item.router_data.request.minor_amount, | ||
| item.router_data.request.currency, | ||
| ) | ||
| .change_context(ConnectorError::AmountConversionFailed)?, |
Contributor
There was a problem hiding this comment.
also use attach printable.
| cardholder_name: card_data.get_cardholder_name().or(item | ||
| .router_data | ||
| .resource_common_data | ||
| .get_billing_full_name())?, |
Contributor
There was a problem hiding this comment.
check if this function is correct or not does it really give the right value
Contributor
There was a problem hiding this comment.
bro as per me this is getting the values from some now known field can you go deeper?
Collaborator
Author
There was a problem hiding this comment.
added a new function to take name from address.billing
gopikrishna000
approved these changes
Dec 12, 2025
AmitsinghTanwar007
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Additional Changes
How did you test it?