Skip to content

Add example of a file editor toolbar button to the toolbar examples - #189

Draft
ktaletsk wants to merge 8 commits into
jupyterlab:mainfrom
ktaletsk:toolbar-button-editor
Draft

ktaletsk wants to merge 8 commits into
jupyterlab:mainfrom
ktaletsk:toolbar-button-editor

Conversation

@ktaletsk

@ktaletsk ktaletsk commented Jan 29, 2022 •

Copy link
Copy Markdown

Implements #188


This will close #188

@welcome

welcome Bot commented Jan 29, 2022

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ktaletsk

Copy link
Copy Markdown
Author

For some reason, I can't get Github to correctly match index.ts in the old and new location

@fcollonval

Copy link
Copy Markdown
Member

For some reason, I can't get Github to correctly match index.ts in the old and new location

The amount of changes is too high for git to consider it as a rename.

Would you mind fixing the CI (in particular the linter)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add example of toolbar button in text editor (+for particular file extension)

2 participants