Prevent deleted garden data from resurfacing - #19
Draft
juliosuas wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_my_garden(request_id)idempotent and prevent watering history from being recreated behind tombstones.Root cause
A deleted row disappeared from the server, so another device interpreted its stale local copy as a new row and upserted it again. Timestamps alone cannot make account-wide reset safe because device clocks are not authoritative.
Deployment order
This is stacked on #18 and intentionally targets
fsociaty/rocio-cloud-recovery.Deploy migration
20260721000100_preserve_garden_deletions.sqltogether with this client. Older clients omit the server epoch and still issue physical DELETE requests; they fail closed and must update. The migration has not been applied to the linked Supabase project yet.Validation
Known follow-up
A second app that stays open can temporarily keep showing a plant tombstoned elsewhere until its next full sync or relaunch. The server will not resurrect it; active-flush UI convergence will be handled next.