Skip to content

feat(warmup): support pod configuration - #125

Merged
zxh326 merged 1 commit into
mainfrom
fix/warmup-pod-config
Aug 13, 2026
Merged

feat(warmup): support pod configuration#125
zxh326 merged 1 commit into
mainfrom
fix/warmup-pod-config

Conversation

@zxh326

@zxh326 zxh326 commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • add WarmUp configuration for hostNetwork, serviceAccountName, schedulerName, dnsPolicy, affinity, enableServiceLinks, imagePullPolicy, and env
  • inherit the new pod-level settings from the selected worker when they are not explicitly configured
  • apply the existing resources field to the warmup container and allow imagePullSecrets to override the inherited worker value
  • regenerate DeepCopy and CRD artifacts

Why

Warmup jobs could not carry several pod-level settings required by the cache group worker, including host networking and related scheduling/DNS configuration. In addition, resources was defined in the API but not applied, and explicit imagePullSecrets were ignored whenever a worker was present.

Impact

Warmup jobs now follow worker pod settings by default for the newly supported fields while allowing per-WarmUp overrides. Warmup-controlled security context, lifecycle, probes, and mount volumes remain unchanged.

Validation

  • go test ./pkg/builder ./api/v1
  • go vet ./pkg/builder ./api/v1
  • git diff --check

@zxh326
zxh326 marked this pull request as ready for review August 12, 2026 13:08
@zxh326
zxh326 requested review from zhijian-pro and a balanced review from Copilot August 13, 2026 02:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds configurable pod settings to WarmUp jobs with worker inheritance and explicit overrides.

Changes:

  • Adds pod, image, environment, and resource configuration.
  • Inherits relevant worker settings.
  • Regenerates DeepCopy and CRD artifacts.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/builder/job.go Applies and inherits WarmUp job settings.
api/v1/warmup_types.go Extends the WarmUp API.
api/v1/zz_generated.deepcopy.go Adds DeepCopy support.
config/crd/bases/juicefs.io_warmups.yaml Updates the WarmUp CRD schema.
dist/crd.yaml Updates the distributed CRD bundle.
Files not reviewed (1)
  • api/v1/zz_generated.deepcopy.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/builder/job.go
@zxh326
zxh326 merged commit abb4349 into main Aug 13, 2026
4 checks passed
@zxh326
zxh326 deleted the fix/warmup-pod-config branch August 13, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants