feat(warmup): support pod configuration - #125
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable pod settings to WarmUp jobs with worker inheritance and explicit overrides.
Changes:
- Adds pod, image, environment, and resource configuration.
- Inherits relevant worker settings.
- Regenerates DeepCopy and CRD artifacts.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pkg/builder/job.go |
Applies and inherits WarmUp job settings. |
api/v1/warmup_types.go |
Extends the WarmUp API. |
api/v1/zz_generated.deepcopy.go |
Adds DeepCopy support. |
config/crd/bases/juicefs.io_warmups.yaml |
Updates the WarmUp CRD schema. |
dist/crd.yaml |
Updates the distributed CRD bundle. |
Files not reviewed (1)
- api/v1/zz_generated.deepcopy.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zhijian-pro
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostNetwork,serviceAccountName,schedulerName,dnsPolicy,affinity,enableServiceLinks,imagePullPolicy, andenvresourcesfield to the warmup container and allowimagePullSecretsto override the inherited worker valueWhy
Warmup jobs could not carry several pod-level settings required by the cache group worker, including host networking and related scheduling/DNS configuration. In addition,
resourceswas defined in the API but not applied, and explicitimagePullSecretswere ignored whenever a worker was present.Impact
Warmup jobs now follow worker pod settings by default for the newly supported fields while allowing per-WarmUp overrides. Warmup-controlled security context, lifecycle, probes, and mount volumes remain unchanged.
Validation
go test ./pkg/builder ./api/v1go vet ./pkg/builder ./api/v1git diff --check