fix(#621) Plural translation starting and ending with a variables fails#640
Open
ben12 wants to merge 6 commits intojsverse:masterfrom
Open
fix(#621) Plural translation starting and ending with a variables fails#640ben12 wants to merge 6 commits intojsverse:masterfrom
ben12 wants to merge 6 commits intojsverse:masterfrom
Conversation
|
|
Contributor
Author
|
@shaharkazaz Ready for review |
Collaborator
|
@ben12 Thank you for the PR and the heads up, I missed this PR. |
f35d22f to
edbd685
Compare
…r forbidden characters
c068fa2 to
d2ade9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #621
What is the new behavior?
To allow variable at start or end of plural translations (ex:
{count, plural, =1 {1 person} other {{count} people}}), we add some forbidden characters for parameters name:Default configuration become:
So in
{count, plural, =1 {1 person} other {{count} people}},{{count} people}}will no longer be processed as variable.Does this PR introduce a breaking change?
Translation keys using braces are now forbidden.
Other information
I have implemented the check for forbidden key characters in
transloco-validatorwith its unit tests.