Repository navigation
refactor: simplify completion handling with stream.finished - #114
Open
Phillip9587 wants to merge 5 commits into
Open
Phillip9587 wants to merge 5 commits into
Phillip9587 wants to merge 5 commits into
Conversation
Phillip9587
requested review from
UlisesGascon,
bjohansebas and
jonchurch
and
a balanced review from Copilot
October 23, 2026 21:29
Contributor
Author
|
legacy tests are failing because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was curious if the tests would pass after removing all the manual socket and event listener handling, and they do. This lets
stream.finished()handle completion and listener cleanup. Original transport errors are recovered fromstream.errored(https://nodejs.org/download/release/v18.0.0/docs/api/stream.html#readableerrored), while premature-close errors and generated HTTP/1 abort errors remain suppressed when there is no stored transport error. I decided to preserve the existing abort behavior because passing those generated errors to the callback would be a breaking change.Added tests confirming that real
ECONNRESETerrors still reach the callback exactly once.