Make LLM agent upgrade to pgx v5#109
Open
meoyawn wants to merge 17 commits into
Open
Conversation
- For pggen row structs, implement pgx.RowScanner. - Remove the typeResolver, since we're punting type resolution to the pgx.Conn type map for now. jschaf#74
# Conflicts: # example/composite/query.sql_test.go # example/custom_types/query.sql_test.go # example/device/query.sql_test.go # example/enums/query.sql_test.go # example/erp/order/customer.sql_test.go # example/inline_param_count/inline0/query.sql_test.go # example/inline_param_count/inline1/query.sql_test.go # example/inline_param_count/inline2/query.sql_test.go # example/inline_param_count/inline3/query.sql_test.go # example/ltree/query.sql_test.go # generate.go # go.mod # go.sum # internal/codegen/golang/gotype/known_types.go # internal/codegen/golang/templater.go # internal/pg/column.go # internal/pg/column_test.go # internal/pg/known_types.go # internal/pg/type_cache.go # internal/pg/type_fetcher.go # internal/pg/types.go # internal/pgdocker/pgdocker.go # internal/pginfer/pginfer.go # internal/pgplan/pgplan.go # internal/pgtest/pg_test_db.go
meoyawn
commented
May 6, 2026
meoyawn
left a comment
meoyawn
left a comment
Author
There was a problem hiding this comment.
README still documents the pgx v4 custom-type flow (pgtype.BinaryDecoder, pgtype.TextDecoder, ConnInfo.RegisterDataType, pgx v4 pool links). This PR now generates RegisterTypes(ctx, *pgx.Conn) and uses pgx/v5, so docs need updating before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocker: #108
building upon: #99
prompt:
gpt-5.5-xhigh output: