Add an option to specify time format#102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 85.76% 85.70% -0.06%
==========================================
Files 1 1
Lines 2452 2449 -3
==========================================
- Hits 2103 2099 -4
- Misses 349 350 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
24a8507 to
4750704
Compare
jrfonseca
left a comment
There was a problem hiding this comment.
Otherwise looks good.
I actually wonder if --time-format option is worthwhile, but have no strong opinion either way.
|
|
||
|
|
||
| MULTIPLICATION_SIGN = chr(0xd7) | ||
| TIME_FORMAT = "%.7g" |
There was a problem hiding this comment.
Given TIME_FORMAT is not a constant, but rather a variable, please rename it to timeFormat.
str(float) prints 16 decimal places, which is too verbose and much more than the precision in the profiles. Print 7 digits by default and allow setting the format with --time-format.
4750704 to
cc55157
Compare
I think picking a format that pleases everyone can be hard and it's easy to make it configurable, so we can avoid arguing about it. |
|
@jrfonseca please take another look btw, |
Good point. Merged. Thanks. |
|
Thank you |
str(float) prints 16 decimal places, which is too verbose and much more than the precision in the profiles. Print 7 digits by default and allow setting the format with --time-format.