Force a single link to an array if requested#8
Open
chadkouse wants to merge 7 commits intojpbochi:masterfrom
Open
Force a single link to an array if requested#8chadkouse wants to merge 7 commits intojpbochi:masterfrom
chadkouse wants to merge 7 commits intojpbochi:masterfrom
Conversation
hal.js
Outdated
Owner
There was a problem hiding this comment.
I believe you could do linkGroupPlus(self._links[link.rel], [link]) and get rid of the forceArray. This way you wouldn't even have to change implementation of linkGroupPlus.
Author
|
Do you think we should handle the case where an array of links with different rels get passed ? |
Author
|
Nevermind - been a long night :) PR coming. |
Owner
There was a problem hiding this comment.
These two ternaries in the same expression are hard to follow.
Owner
There was a problem hiding this comment.
maybe something like var links = (arguments.length === 1) ? link : extractLinks.apply(this, arguments);
and extractLinks would always receive two arguments. A relation and an href (or array of hrefs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7