Cleanup JS style guide.#61
Closed
eddieajau wants to merge 1 commit intojoomla:gh-pagesfrom
eddieajau:gh-pages
Closed
Cleanup JS style guide.#61eddieajau wants to merge 1 commit intojoomla:gh-pagesfrom eddieajau:gh-pages
eddieajau wants to merge 1 commit intojoomla:gh-pagesfrom
eddieajau:gh-pages
Conversation
Contributor
Author
There was a problem hiding this comment.
I removed this because it should be up to the developer to choose. Opinion is divided over whether i is best practice or not.
Contributor
There was a problem hiding this comment.
Opinions are also divided on tabs vs spaces. It is precisely one of the reasons style guides exist, for a particular project to provide their expectations of syntax, especially when debatable (and mostly futile), for consistencies sake.
Contributor
|
@eddieajau What do you want to do with this PR considering the branch has conflicts and we are moving away from the gh pages (see PR #141 ) |
Contributor
Author
|
I think it's safe to say it can be closed for want of a seconder :) |
wilsonge
pushed a commit
to wilsonge/coding-standards
that referenced
this pull request
Oct 1, 2018
use object oriented style property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignoreNote, I'm propose that the
elsekeyword start on its own line rather than used inline. I think this makes for a better read but it's not a hill I'm prepared to die on.