Skip to content

fix: update macOS icon sizes#21

Merged
johannesjo merged 4 commits intojohannesjo:mainfrom
cledoux95:fix/macos-logo-size
Mar 20, 2026
Merged

fix: update macOS icon sizes#21
johannesjo merged 4 commits intojohannesjo:mainfrom
cledoux95:fix/macos-logo-size

Conversation

@cledoux95
Copy link
Contributor

Summary

  • Updated macOS app icons (128x128.png, 128x128@2x.png, icon.icns, icon.png) to correct sizes for proper display in Dock, Finder, and app switcher

Updated icon size

updated-logo-size

Test plan

  • Build the macOS app (npm run build) and verify the icon renders at correct size in the Dock
  • Verify icon appearance in Finder and app switcher (Cmd+Tab)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Owner

@johannesjo johannesjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this and sorry for the late reply. Somehow I wasn't receiving notifications for PRs opened here.

Icon padding affects Linux

The updated PNGs (icon.png, 128x128.png, 128x128@2x.png) have inner transparent padding to fix macOS Dock sizing — but these same files are used by Linux (taskbar, tray, BrowserWindow). macOS never actually reads the PNGs:

  • macOS build: electron-builder uses icon.icns (already present in build/)
  • macOS runtime: getIconPath() in electron/main.ts:69 returns undefined on non-Linux
  • Linux build + runtime: uses icon.png and the 128x128 variants exclusively

Suggested fix: Revert the 3 PNG files to their originals (no padding) and keep only the icon.icns change. This fixes macOS without shrinking Linux icons. No config or code changes needed.

@cledoux95
Copy link
Contributor Author

All set

@johannesjo
Copy link
Owner

Thank you very much!

@johannesjo johannesjo merged commit 4792390 into johannesjo:main Mar 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants