Skip to content

Fix memory leak in nvmpi_enc, also add more cleanup to nvmipi dec/enc#82

Open
vietnx wants to merge 4 commits into
jocover:masterfrom
vietnx:master
Open

Fix memory leak in nvmpi_enc, also add more cleanup to nvmipi dec/enc#82
vietnx wants to merge 4 commits into
jocover:masterfrom
vietnx:master

Conversation

@vietnx

@vietnx vietnx commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

No description provided.

HunterAP23 added a commit to HunterAP23/jetson-ffmpeg that referenced this pull request May 4, 2021
@wangtingbo

Copy link
Copy Markdown

@jocover ,I found the same problem,when use nvmpi_enc. I had fixed “nvmpi_encoder_close”,release ctx->packets[index]。

@GavinDarkglider GavinDarkglider left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vietnx Just a thought on this, dpkg is a bad way to get version, much better to pull it from tegra version file in /etc. A lot of distros dont have dpkg, and this will completely break this on them. Also it is really dirty to be running external commands in the background in a lib. Where with a text file, it is open and parse. much faster, and clean. You also dont have to include/wait for extra threads.

@gjrtimmer

Copy link
Copy Markdown

This is addressed in the gjrtimmer/jetson-ffmpeg fork:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants