Repository navigation
Add VisualEditor support for math/chem formulas - #80
Merged
Merged
Conversation
- Add VE dialogs, context items, and model/CE nodes for math and chem formulas under resources/ve/ - Add i18n/en.json, i18n/qqq.json, and i18n/ko.json for the new VE dialog strings - Add demo tooling for VE animations (hack/demo/ve_animation.mjs, hack/demo/demo-animations.yaml) and split demo screenshots/gifs by MediaWiki version under docs/ - Update Makefile and AGENTS.md with the new demo/animation targets
- extension.json: version 1.0.1 -> 1.1.0 - demo-animations.yaml: comment out 1.45, tweak default doc's Korean text - ve_animation.mjs: update recorded page title, minor formatting - Regenerate docs/animations/1.43/animation-default.gif, drop the 1.45 one to match demo-animations.yaml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f74709c8b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Shorten overly verbose comments in Makefile, hack/demo/render.php, and hack/demo/demo.sh without changing behavior - Remove the screenshot/animation usage paragraphs from AGENTS.md
- Add hack/demo/demo.md documenting the demo/screenshot/animation make targets (moved out of AGENTS.md) - ve_animation.mjs: tweak recorded page title - Regenerate docs/animations/1.43/animation-default.gif
- script.onerror now rejects scriptLoadPromise and clears the loaded flag, so a failed load doesn't leave mw.libs.smj.typeset() callers (e.g. ve.ce.MWFormulaNode.afterRender) pending forever, and a later call can retry - The wikipage.content hook now typesets a later fire's own content (e.g. a live preview) instead of only ever loading the script once and never touching subsequent content
…bled wgSmjDelimitersEnabled lets $...$/$$...$$ appear as bare text with no .smj-container wrapper, so scoping a later wikipage.content fire's typeset call to just .smj-container elements (as the previous fix did) missed that content entirely when delimiters are on. Pass the whole $content fragment to MathJax.typesetPromise() in that case, matching how the initial page load already sets startup.elements to null (whole document) for the same setting; the opacity fix-up still only targets whatever .smj-container elements are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources/ve/)i18n/en.json,i18n/qqq.json,i18n/ko.jsonhack/demo/ve_animation.mjs,hack/demo/demo-animations.yaml), and split existing demo screenshots/gifs by MediaWiki version underdocs/MakefileandAGENTS.mdwith the new demo/animation targetsTest plan
make checksmake demo/make animationsagainst a local MediaWiki instance to confirm the VE math/chem dialogs work as expected