Skip to content

Fix order_sell_stop_loss function argument order to resolve TypeError #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humza-sami wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix order_sell_stop_loss function argument order to resolve TypeError #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions robin_stocks/robinhood/orders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ def order_buy_stop_loss(symbol, quantity, stopPrice, account_number=None, timeIn
the price, and the quantity.

"""
return order(symbol, quantity, "buy", account_number, None, stopPrice, timeInForce, extendedHours, jsonify)
return order(symbol=symbol, quantity=quantity, side="buy", limitPrice=None, stopPrice=stopPrice, account_number=account_number, timeInForce=timeInForce, extendedHours=extendedHours, jsonify= jsonify)


@login_required
Expand Down Expand Up @@ -631,7 +631,7 @@ def order_sell_stop_loss(symbol, quantity, stopPrice, account_number=None, timeI
the price, and the quantity.

"""
return order(symbol, quantity, "sell", account_number, None, stopPrice, timeInForce, extendedHours, jsonify)
return order(symbol=symbol, quantity=quantity, side="sell", limitPrice=None, stopPrice=stopPrice, account_number=account_number, timeInForce=timeInForce, extendedHours=extendedHours, jsonify= jsonify)


@login_required
Expand Down
6 changes: 5 additions & 1 deletion tests/test_robinhood.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,4 +835,8 @@ def isFloat(f):
assert isFloat(order['quantity'])
assert isFloat(order['cumulative_quantity'])
if(order['state'] == 'filled'):
assert (order['quantity'] == order['cumulative_quantity'])
assert (order['quantity'] == order['cumulative_quantity'])

def test_stop_loss_order(cls):
order_details = r.order_sell_stop_loss()
assert ('account_number' in order_details)