-
Notifications
You must be signed in to change notification settings - Fork 0
fix: guard file type override for virtual files #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
af0d2df
fix: guard file type override for virtual files
jingu 067768d
fix: guard file type override for virtual files
jingu e6c6740
fix: guard file type override for virtual files
jingu 6fe0cca
Update src/test/kotlin/io/github/jingu/idea_qiq_plugin/lang/QiqFileTy…
jingu 11e95fc
Merge remote-tracking branch 'origin/develop' into fix-copy-paste-fil…
jingu ca931c9
fix test
jingu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
src/test/kotlin/io/github/jingu/idea_qiq_plugin/lang/QiqFileTypeOverriderTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| package io.github.jingu.idea_qiq_plugin.lang | ||
|
|
||
| import com.intellij.lang.Language | ||
| import com.intellij.openapi.application.ReadAction | ||
| import com.intellij.openapi.application.WriteAction | ||
| import com.intellij.openapi.fileTypes.FileType | ||
| import com.intellij.openapi.vfs.LocalFileSystem | ||
| import com.intellij.openapi.vfs.VirtualFile | ||
| import com.intellij.testFramework.LightVirtualFile | ||
| import com.intellij.testFramework.junit5.RunInEdt | ||
| import com.intellij.testFramework.junit5.impl.TestApplicationExtension | ||
| import org.junit.jupiter.api.Assertions.assertEquals | ||
| import org.junit.jupiter.api.Assertions.assertNull | ||
| import org.junit.jupiter.api.Assertions.assertTrue | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.ExtendWith | ||
| import java.nio.charset.StandardCharsets | ||
| import java.nio.file.Files | ||
| import java.util.Comparator | ||
|
|
||
| @RunInEdt | ||
| @ExtendWith(TestApplicationExtension::class) | ||
| class QiqFileTypeOverriderTest { | ||
|
|
||
| private val overrider = QiqFileTypeOverrider() | ||
|
|
||
| @Test | ||
| fun `does not override LightVirtualFile`() { | ||
| val lightFile = LightVirtualFile( | ||
| "sample.php", | ||
| Language.ANY, | ||
| "{{ setSection('header') }}\n{{ endSection() }}" | ||
| ) | ||
|
|
||
| val type = overrider.getOverriddenFileType(lightFile) | ||
| assertNull(type, "LightVirtualFile must not be overridden as Qiq") | ||
| } | ||
|
|
||
| @Test | ||
| fun `overrides local virtual file`(@org.junit.jupiter.api.io.TempDir tempDir: java.nio.file.Path) { | ||
| val text = """ | ||
| {{ setSection('header') }} | ||
| content | ||
| {{ endSection() }} | ||
| """.trimIndent() | ||
|
|
||
| val path = tempDir.resolve("template.php") | ||
| Files.writeString(path, text, StandardCharsets.UTF_8) | ||
|
|
||
| val virtualFile = WriteAction.compute<VirtualFile?, RuntimeException> { | ||
| LocalFileSystem.getInstance().refreshAndFindFileByIoFile(path.toFile()) | ||
| } ?: error("Virtual file not found for temp file") | ||
|
|
||
| val type: FileType? = ReadAction.compute<FileType?, RuntimeException> { | ||
| overrider.getOverriddenFileType(virtualFile) | ||
| } | ||
|
|
||
| assertEquals(QiqFileType, type, "Local template should be detected as Qiq") | ||
| assertTrue( | ||
| virtualFile.getUserData(QiqFileTypeOverrider.QIQ_MARKER) == true, | ||
| "Marker flag should be set to avoid repeated re-evaluation" | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.