Enhance entity creation with base field expansion and dynamic id key#271
Open
chrisolof wants to merge 3 commits intojhedstrom:masterfrom
Open
Enhance entity creation with base field expansion and dynamic id key#271chrisolof wants to merge 3 commits intojhedstrom:masterfrom
chrisolof wants to merge 3 commits intojhedstrom:masterfrom
Conversation
…nsion Per FieldHandlerInterface::expand(), field handlers expect an array of field values. The source entity object passed into expandEntityFields() often has an inconsistent structure across its various field properties, sometimes holding a single value, sometimes holding an array of values (as expected), and sometimes holding an array of composite field parts for a single field value. Consistently providing field handlers the field values in the structure they expect allows them to expand each field value correctly. jhedstromgh-270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #270.
Pairs really well with jhedstrom/drupalextension/pull/661.