Repository navigation
Close the MongoClient in destroy() instead of stop() - #68
Merged
Merged
Conversation
JChannel.disconnect() and a subsequent connect() cycle stop() and start()
without re-running init(), so closing the client in stop() left a
reconnected channel with a closed client ("state should be: open").
The client is created in init() and is now closed in the matching
destroy(), after JDBC_PING2.stop() has removed the local entry.
destroy() also drops the collection, so the collection of the closed
client is not handed out afterwards.
Signed-off-by: rsobies <rsobies@gmail.com>
rhusar
approved these changes
Nov 14, 2026
Member
|
Thanks @rsobies |
Member
|
btw always reference the issue from the commit also ideally in the text somewhere include 'fixes #xyz' which github uses to autoclose issues. |
Member
|
Here's a quick fix to the PR #69 -- but only nits and precautions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.