Fix Elixir 1.18 "clause will never match" warnings#13
Open
justinludwig wants to merge 1 commit intojfrolich:masterfrom
Open
Fix Elixir 1.18 "clause will never match" warnings#13justinludwig wants to merge 1 commit intojfrolich:masterfrom
justinludwig wants to merge 1 commit intojfrolich:masterfrom
Conversation
Fixes warnings like the following by providing a hint to the Elixir
compiler about the result type of rule blocks:
```
warning: the following clause will never match:
{:ok, description}
because it attempts to match on the result of:
case actor.admin? do
x when x === false or x === nil -> :next
_ -> :ok
end
which has type:
dynamic(:next or :ok)
typing violation found at:
│
51 │ rule [:update, :delete],
│ ~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ test/authorize_test.exs:51: Item."admins can update and delete any item"/3
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warnings like the following by providing a hint to the Elixir compiler about the result type of rule blocks: