Skip to content

Getting snippet-detection from centrelized config#691

Merged
orto17 merged 1 commit intojfrog:devfrom
orto17:snippet-detection
Mar 8, 2026
Merged

Getting snippet-detection from centrelized config#691
orto17 merged 1 commit intojfrog:devfrom
orto17:snippet-detection

Conversation

@orto17
Copy link
Contributor

@orto17 orto17 commented Mar 5, 2026

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

@orto17 orto17 added the new feature Automatically generated release notes label Mar 5, 2026
return true
}
}
if params.resultsContext.IncludeSnippetDetection {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can set resultsContext to be IncludeSnippetDetection=true if not the config profile? this seems redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the case where the condiguration comes from the env (Assafa implementation)

@orto17 orto17 merged commit f7f7b02 into jfrog:dev Mar 8, 2026
18 of 19 checks passed
@attiasas attiasas added ignore for release Automatically generated release notes and removed new feature Automatically generated release notes labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants