Issue #15667 - HTTP/2/3 client discards response on abrupt connection close - #15669
Draft
lachlan-roberts wants to merge 1 commit into
Draft
lachlan-roberts wants to merge 1 commit into
lachlan-roberts wants to merge 1 commit into
Conversation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Member
Author
|
The test failures don't look like flakes. |
lachlan-roberts
marked this pull request as draft
September 1, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15667
In the test
HttpClientStreamTest#testDownloadWithFailurethe server sends half of the response then abruptly closes the TCP connection.However since the HEADERS/DATA frames are delivered asynchronously using the channels
SerializedInvoker, the abort is racing against the processing of the headers frame.This PR sends the abort through the same
SerializedInvoker, so it is serialized behind any events already received.