Added Support to add an Alias Record#73
Open
AltamashShaikh wants to merge 3 commits intojethrocarr:masterfrom
Open
Added Support to add an Alias Record#73AltamashShaikh wants to merge 3 commits intojethrocarr:masterfrom
AltamashShaikh wants to merge 3 commits intojethrocarr:masterfrom
Conversation
Also added cname validation to check if @ is not entered in name
Owner
|
Thanks for the PR @AltamashShaikh ! Looking at this code and how Route53 ALIAS records are handled, I believe this feature would break compatibility for other DNS servers such as Bind? So it works for users who are pure Route53, but will not allow for portability. |
Author
|
what if I add a check for route53 only ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a support to add Alias Records for Route53(DB Upgrade version_20180508_upgrade.sql should be executed).
There was also one issue if we add cname for '@ ', this is not allowed in Route53 have added a validation check for it
I have tested the above changes and it works as intended, can you please review it and merge it accordingly