Fix UB in file_merging_iterator sentinel and is_member comparison#90
Merged
jermp merged 1 commit intojermp:masterfrom Mar 10, 2026
Merged
Fix UB in file_merging_iterator sentinel and is_member comparison#90jermp merged 1 commit intojermp:masterfrom
jermp merged 1 commit intojermp:masterfrom
Conversation
file_merging_iterator used std::numeric_limits<T>::max() as a sentinel value, but minimizer_tuple has no std::numeric_limits specialization. This returns a default-constructed object with uninitialized members (UB), causing segfaults when merging >16 minimizer files via the winner tree path. Use T::max() instead, which minimizer_tuple properly defines. Also fix is_member() which compared lookup_result directly against uint64_t instead of comparing lookup_result.kmer_id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thank you, Claude Patro! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_merging_iterator used std::numeric_limits::max() as a sentinel value, but minimizer_tuple has no std::numeric_limits specialization. This returns a default-constructed object with uninitialized members (UB), causing segfaults when merging >16 minimizer files via the winner tree path. Use T::max() instead, which minimizer_tuple properly defines.
Also fix is_member() which compared lookup_result directly against uint64_t instead of comparing lookup_result.kmer_id.