Add std::error_code and error category constructors to system_error#331
Open
Seele-Official wants to merge 1 commit into
Open
Add std::error_code and error category constructors to system_error#331Seele-Official wants to merge 1 commit into
Seele-Official wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends
cpptrace::system_errorwith constructors accepting:std::error_codeconst std::error_category&This brings
cpptrace::system_errorcloser to the interface provided bystd::system_error.Details
The existing
(int, std::string&&)constructor has been preserved for source compatibility. Its implementation now delegates to the newstd::error_codeconstructor usingstd::generic_category(), preserving the existing behavior while avoiding duplicate initialization and message-formatting logic.Closes #326