Skip to content

JENKINS-75602: add error proper errorhandling to the checkUpdatesServer method in PluginManager class #23920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adhamahmad wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −0
Open

JENKINS-75602: add error proper errorhandling to the checkUpdatesServer method in PluginManager class #23920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7bb0c7
JENKINS-75602: add error proper errorhandling to the checkUpdatesServ…
adhamahmad Dec 7, 2025
ac667c1
Add logging to checkUpdatesServer()
adhamahmad Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/java/hudson/PluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2177,13 +2177,15 @@ private FormValidation checkUpdatesServer() throws Exception {
FormValidation v = site.updateDirectlyNow();
if (v.kind != FormValidation.Kind.OK) {
// Stop with an error
LOGGER.log(Level.SEVERE, "Failed to check updates server: " + site.getUrl());
return v;
}
}
for (DownloadService.Downloadable d : DownloadService.Downloadable.all()) {
FormValidation v = d.updateNow();
if (v.kind != FormValidation.Kind.OK) {
// Stop with an error
LOGGER.log(Level.SEVERE, "Failed to update downloadable: " + d.getUrl());
return v;
}
}
Expand Down