Skip to content

Conversation

@karthikbhandary2
Copy link

Fixes #23860

This PR adds severity levels to Jenkins system messages with proper styling and visual indicators:

  • Added 5 severity types: INFO, WARNING, DANGER, SUCCESS, MAINTENANCE
  • Each severity displays with appropriate icon and color coding
  • Uses Jenkins design tokens for consistent styling
  • Preserves existing markup formatter functionality
  • Configuration via radio buttons in system settings

Testing done

  • Manually tested all 5 severity levels (INFO, WARNING, DANGER, SUCCESS, MAINTENANCE) in Jenkins configuration
  • Verified system message displays with correct icons and styling for each severity
  • Confirmed markup formatter works with both plain text and formatted content
  • Tested form submission and persistence of selected severity
  • Verified SCSS compilation and proper use of Jenkins design tokens
  • Ran mvn -Plight-test test to ensure no regressions

Proposed changelog entries

  • Add severity levels to system message with proper styling and icons

Proposed changelog category

/label rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

Images of the System Message:
image
image
image
image
image
image

@welcome
Copy link

welcome bot commented Dec 4, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 4, 2025
@karthikbhandary2
Copy link
Author

/label web-ui

@comment-ops-bot comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Dec 6, 2025
@karthikbhandary2
Copy link
Author

@timja Please review the PR and let me know if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: System Message Rendering Is Not Prominent Enough

1 participant