test: couvrir la progression --stream et l'erreur de limite de frame (issue #1) - #4
Conversation
…(issue #1) Le transfert chunké était déjà implémenté sur master ; ces tests vérifient explicitement les événements de progression par chunk en mode --stream et l'erreur claire lorsqu'une frame dépasse la limite du relay. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Automaintainer Review Verdict: APPROVED — Tests-only PR (74 additions, 0 deletions in filetransfer_test.go). Two new tests cover the targeted scenarios: per-chunk --stream progress events and clear error on relay frame limit exceeded (issue #1). CI build passes. captureStdout helper is clean. Logic is sound. No production code changes, no external review concerns (bot comments were rate-limit notices only). |
|
Approved by automaintainer review team — ready for human merge |
Automated maintenance run by automaintainer.
Focus: Fix issue #1: cp stalls silently on large files (>=200MB) through the WebSocket relay. The client reads the entire file into memory and sends it as a single WS message, exceeding the relay's max frame size. Implement chunked streaming (4-8MB frames) at the transport layer in filetransfer.go, emit per-chunk progress events in --stream mode, and surface a clear error when a payload exceeds the relay's frame limit. Add tests in filetransfer_test.go and integration_stream_test.go. Ensure go build ./... and go test ./... pass.
Branch:
am/am-94c6fc-tih6vvDiff: