Skip to content

test: couvrir la progression --stream et l'erreur de limite de frame (issue #1) - #4

Merged
javimosch merged 1 commit into
masterfrom
am/am-94c6fc-tih6vv
Jul 20, 2026
Merged

test: couvrir la progression --stream et l'erreur de limite de frame (issue #1)#4
javimosch merged 1 commit into
masterfrom
am/am-94c6fc-tih6vv

Conversation

@javimosch

Copy link
Copy Markdown
Owner

Automated maintenance run by automaintainer.

Focus: Fix issue #1: cp stalls silently on large files (>=200MB) through the WebSocket relay. The client reads the entire file into memory and sends it as a single WS message, exceeding the relay's max frame size. Implement chunked streaming (4-8MB frames) at the transport layer in filetransfer.go, emit per-chunk progress events in --stream mode, and surface a clear error when a payload exceeds the relay's frame limit. Add tests in filetransfer_test.go and integration_stream_test.go. Ensure go build ./... and go test ./... pass.

Branch: am/am-94c6fc-tih6vv

Diff:

filetransfer_test.go | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

…(issue #1)

Le transfert chunké était déjà implémenté sur master ; ces tests vérifient
explicitement les événements de progression par chunk en mode --stream et
l'erreur claire lorsqu'une frame dépasse la limite du relay.

Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@javimosch, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86a67f11-95af-4879-9170-46fbd0a51914

📥 Commits

Reviewing files that changed from the base of the PR and between 89c9149 and 4003705.

📒 Files selected for processing (1)
  • filetransfer_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch am/am-94c6fc-tih6vv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@javimosch

Copy link
Copy Markdown
Owner Author

Automaintainer Review Verdict: APPROVED — Tests-only PR (74 additions, 0 deletions in filetransfer_test.go). Two new tests cover the targeted scenarios: per-chunk --stream progress events and clear error on relay frame limit exceeded (issue #1). CI build passes. captureStdout helper is clean. Logic is sound. No production code changes, no external review concerns (bot comments were rate-limit notices only).

@javimosch

Copy link
Copy Markdown
Owner Author

Approved by automaintainer review team — ready for human merge

@javimosch
javimosch merged commit cf61778 into master Jul 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant