Skip to content

Add support for underscore separator in numbers - #8

Open
Victor4X wants to merge 2 commits into
jaredreich:masterfrom
Victor4X:feat_underscore_readability
Open

Add support for underscore separator in numbers#8
Victor4X wants to merge 2 commits into
jaredreich:masterfrom
Victor4X:feat_underscore_readability

Conversation

@Victor4X

Copy link
Copy Markdown

Closes #7

If you want this implemented in a different way, feel free to tell me how :)

@netlify

netlify Bot commented Sep 20, 2022

Copy link
Copy Markdown

Deploy Preview for calcutext ready!

Name Link
🔨 Latest commit 110841d
🔍 Latest deploy log https://app.netlify.com/sites/calcutext/deploys/6329666fac0a03000854149b
😎 Deploy Preview https://deploy-preview-8--calcutext.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Victor4X

Copy link
Copy Markdown
Author

Something must've changed between your last deploy and today, as netlify's deploy now fails with this error:

Failed to compile.
./src/Banner.js
  Line 222:21:  Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener  react/jsx-no-target-blank
​
────────────────────────────────────────────────────────────────
  "build.command" failed                                        
────────────────────────────────────────────────────────────────

I'm not sure if you want this fixed in a separate PR, but for now I will add a commit to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for underscores in numbers for improved readability

1 participant