Skip to content

Fix highlight action ambiguity and captured X video quality - #92

Merged
jamditis merged 2 commits into
masterfrom
fix/highlight-selection-captured-quality
Sep 14, 2026
Merged

jamditis merged 2 commits into
masterfrom
fix/highlight-selection-captured-quality

Conversation

@jamditis

Copy link
Copy Markdown
Owner

Whole-highlight URLs do not identify the viewed item. Single downloads now announce that they will download the whole highlight, and Copy stops with an individual-item-link notice instead of copying the first tray item. Explicit item links and Download all retain their existing behavior.

Advanced-mode X video downloads now apply the saved width cap when the clicked video's CDN source or poster identifies a captured asset group. Renditions from other autoplaying tweets cannot satisfy that cap. The default selection and capture fallback for private or uncorrelated videos remain unchanged.

Closes #82. Closes #88.

Validation: 864 tests passed; ESLint and production build passed. Regression tests cover concurrent capture groups, correlation failure, saved-preference routing, and highlight single/all/copy behavior. Live authenticated Instagram/X browser behavior was not tested.

Project

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T12:16:29.992777Z 32b5da3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32b5da3897

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/background.js Outdated
@jamditis
jamditis merged commit 8d07848 into master Sep 14, 2026
1 check passed
@jamditis
jamditis deleted the fix/highlight-selection-captured-quality branch September 14, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply download quality to advanced-mode captured X videos Highlight single-item and copy actions download the whole highlight

1 participant