Recreate BitBetter containers before pruning images - #290
Open
Flol0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When BitBetter rebuilds images for the currently installed Bitwarden
version,
bitwarden.sh updatemay reportUpdate not needed.The existing API and Identity containers then remain attached to the old
image IDs. As a result, the subsequent
docker image prune -acan removethe newly built images because no containers reference them yet.
Solution
When BitBetter images were rebuilt, force-recreate the
apiandidentityservices before pruning unused images.
This ensures that the containers use the newly built images before
docker image prune -aruns.``