Check file existence before searching for lyrics#498
Merged
Conversation
jacquesh
reviewed
Apr 27, 2026
Owner
jacquesh
left a comment
jacquesh
left a comment
There was a problem hiding this comment.
Some tweaks but seems like a reasonable thing to do. Could we please also add something to the changelog for this? As I expect the CI will highlight.
Contributor
Author
|
Addressed the feedback and pushed an update. |
sceriz
force-pushed
the
skip-search-missing-files
branch
from
ec54d2f to
9323745
Compare
Owner
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a playlist has tracks that no longer exist on disk, foobar2000 skips past them instantly to the next track. The plugin still tries to search lyrics for each one though, so it ends up rapidly downloading lyrics for all of them and creating the full directory structure for each of the missing file paths in the playlist. You can end up with massive folder trees containing nothing but lyric files.
This adds a check so that lyrics search is skipped if file doesn't exist. Compiled and tested on my end, works as expected.