[codex] Make adapter sync non-destructive#1888
Open
chiehwangs wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/fetch-adapters.js.Root Cause
scripts/fetch-adapters.jsran during global install or explicit adapter sync and used recursive forced deletion plus direct file deletion against~/.opencli. That could remove user adapter directories or files without an explicit per-item confirmation step.A second issue was in
hasAllManifests: it only checked that manifest files existed. Ifcli-manifest.jsonexisted but contained invalid JSON, the fast completion path still ran and returned empty completions instead of falling back to full discovery.Validation
HOME="$PWD/.local-home" npx vitest run --project unit src/install-safety.test.tsHOME="$PWD/.local-home" npx vitest run --project unit src/completion-fast.test.tsHOME="$PWD/.local-home" npx vitest run --project unitHOME="$PWD/.local-home" npm run typechecknode --check scripts/fetch-adapters.jsHOME="$PWD/.local-home" OPENCLI_FETCH=1 node scripts/fetch-adapters.jsHOME="$PWD/.local-home" node dist/src/main.js hackernews top --limit 1 -f json