fix(browser): persist interceptor across navigation#1870
Open
cnYui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
installInterceptor(pattern)only patched the current document before this change. If a caller installed the interceptor and then navigated, the new document lost the fetch/XHR monkey patch, so requests fired by the loaded page could not be captured.This keeps the existing current-document
evaluate()injection and, when the page exposes CDP, also registers the same interceptor source throughPage.addScriptToEvaluateOnNewDocument. CDP registration is best-effort so non-CDP backends keep the previous behavior instead of failing interceptor setup.Related issue: fixes #584
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorN/A: this PR does not add or modify an adapter.
Screenshots / Output