Skip to content

v1.4.0 - #162

Merged
itsvic-dev merged 5 commits into
itsvic-dev:masterfrom
wiktordudek:next-version
Jul 20, 2025
Merged

v1.4.0#162
itsvic-dev merged 5 commits into
itsvic-dev:masterfrom
wiktordudek:next-version

Conversation

@wiktordudek

Copy link
Copy Markdown
Contributor

No description provided.

@wiktordudek
wiktordudek marked this pull request as draft July 17, 2025 21:36
Co-authored-by: 脕kos Mikl贸s <me@miklosakos.hu>
@itsvic-dev

Copy link
Copy Markdown
Owner

should we merge this now?

@wiktordudek

Copy link
Copy Markdown
Contributor Author

Yeah, sure 馃槃

@wiktordudek
wiktordudek marked this pull request as ready for review July 20, 2025 15:01
@itsvic-dev

Copy link
Copy Markdown
Owner

conflicts should be resolved first

@Zan1456

Zan1456 commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

Please wait for #160

@itsvic-dev

Copy link
Copy Markdown
Owner

Please wait for #160

#160 will take a while for me to review and i'd rather bring these in a future release. it's been a while since the last release and we really should release this ASAP to bring new services and crash fixes to users

@Zan1456

Zan1456 commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

Once I'm home, I'm going to push the express One support

@itsvic-dev

Copy link
Copy Markdown
Owner

Once I'm home, I'm going to push the express One support

please do so in a separate PR/branch and we'll merge it for 1.4.0.

@wiktordudek

Copy link
Copy Markdown
Contributor Author

Can we please avoid adding any new features at the last minute? I鈥檝e already tested everything before this particular release.

Testing your changes will take some time, and definitely shouldn鈥檛 be merged right before the release of the new version.

@itsvic-dev

itsvic-dev commented Jul 20, 2025 •

Copy link
Copy Markdown
Owner

Can we please avoid adding any new features at the last minute? I鈥檝e already tested everything before this particular release.

Testing your changes will take some time, and definitely shouldn鈥檛 be merged right before the release of the new version.

i would like to review and merge at the very least Express One support, as Zan already has a working version in their tree.
image

@Zan1456

Zan1456 commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

Forget it, as I'd have to rewrite some of the code, since it's different because of the categorization.

@wiktordudek

wiktordudek commented Jul 20, 2025 •

Copy link
Copy Markdown
Contributor Author

Okay, let's merge it

@itsvic-dev
itsvic-dev merged commit 1a3dc86 into itsvic-dev:master Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants