chore: removed the migration path from JiraEconomics - #348
Open
tuj wants to merge 1 commit into
Open
Conversation
jeppekroghitk
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/8000
Description
Removes the JiraEconomics migration path.
app:migrate-from-jira-economicswas a one-shotcutover helper: it hand-created
doctrine_migration_versions, markedVersion20230101000000as already run, then dropped
messenger_messagesandmigration_versions. That cutover islong done, and
docs/migration-from-jira-economics.mdwas already dead — five of the sixcommands it told you to run no longer exist (
app:sync-projects,app:sync-accounts,app:migrate-customers,app:sync-issues,app:sync-worklogs).Nothing was wired to the command beyond the
#[AsCommand]autowiring — no service definition,no PHPStan baseline entry, no tests, no env vars, no separate Doctrine connection — so deleting
it is self-contained.
Also cleans up the references that would otherwise go stale:
CLAUDE.md— dropped the sentence pointing at the deleted command and removed it from theconsole-command list (and added the missing
app:anonymize-worklogswhile in there).README.md— "e.g. Jira" → "e.g. Leantime", since Leantime is the only entry inDataProviderService::IMPLEMENTATIONS.InvoiceControllerandBillingService— reworded three "backwards compatible withJiraEconomics" comments. Comments only. The logic they guard still matters for imported
rows: the free-text
paidByAccount/defaultReceiverAccountfallback, and theINTERN/EKSTERNlocked-type literals that recorded invoices carry.The
jira_key/jira_idcolumns inmigrations/Version20230101000000.phpandVersion20230101000002.phpare left alone — executed history, and the base of the migration chain.Checklist