Fix issues with jorek2vtk - #43
Merged
matthiashoelzl merged 2 commits intoSep 29, 2026
Merged
matthiashoelzl merged 2 commits into
matthiashoelzl merged 2 commits into
Conversation
LukeTheWalker
approved these changes
Sep 24, 2026
edo01
approved these changes
Sep 24, 2026
matthiashoelzl
approved these changes
Sep 29, 2026
matthiashoelzl
left a comment
matthiashoelzl
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started getting errors when running jorek2vtk which this fixes.
Basically, in mod_element_rtree, with a stellarator model, line 14 sets ND to 3, lines 156 and 157 allocates 3 components for min/max_vals, but only the first two were initialised. Therefore, it was just filled from the heap and if you're unlucky, you get errors. This PR initialises the extra slot even though it's not used in the 2D rtree.
Maybe a more elegant fix would be to get rid of this phi slot when "use_3D" is not set, but I think you'd have to get access to this "use_3D" parameter right at line 14 where ND is set - maybe someone else knows a better way to do this?